Java OpenGroupware API - annotations

Hi,

i took a look @ your JOGI stuff.
It's a very nice thing ;)

But there are two things to annotate:

1. your methods fetching objects from server returning lists.
 i already told with helge about that and we think this is not the best 
way doing so.

 if there are queries with large results, this results in a expensive 
utilization of resources.
 the better way should be to return iterator.

 for the present you can simply return list.iterator();
 in the future the better way is to implement an own iterator wich 
reads the results
 from the stream as the're needed.

 so the client gets the iterator and each element is read when its needed.

 maybe short queries can get slower but large queries will be fasten up 
extremly.
 i think in most cases the client will iterate over the lists anyway, 
don't they?

 is it possible to change your API. please think about that.

2. the second one is only a short tip.
 like you i'm using eclipse for development.
 you cecked in the libs JOGI needs.

 it seems you're importing the libs using the "add external jar feature".
 the better way is using variables or the "add jar" feature, so it runs 
everywhere
 without changing any settings.

at last i've a short question about the classpath....
u're using "net.sourceforge.ogojogi...".

ok, currently the project is hosted there but i think 
"org.opengroupware.ogojogi"
sounds much better...don't it?

and eclipse supports refactoring ;)

that's all for the moment.
if you need/want help for your project...ask me for!

regards,
burkhard


--
OpenGroupware.org XML-RPC
xmlrpc@xxxxxxxxxxxxxxxxx
http://mail.opengroupware.org/mailman/listinfo/xmlrpc