Re: t/perl/ithreads.t revisited

Stas Bekman wrote:
> Steve Hay wrote:
> [...]
>
> > After making this change I found that reload.t now fails test 2.  This 
> > patch (against current CVS, since I can't get SVN working) fixes that:
> >
> > Index: t/modules/reload.t
> > ===================================================================
> > RCS file: /home/cvspublic/modperl-2.0/t/modules/reload.t,v
> > retrieving revision 1.4
> > diff -u -u -r1.4 reload.t
> > --- t/modules/reload.t  11 Sep 2004 01:02:28 -0000      1.4
> > +++ t/modules/reload.t  26 Nov 2004 18:05:21 -0000
> > @@ -53,7 +53,7 @@
> >  touch_mtime($test_file);
> >
> >  {
> > -    my $expected = join '', map { "$_:" . uc($_) . "\n" } sort @tests;
> > +    my $expected = join '', map { "$_:$_\n" } sort @tests;
> >      my $received = get_body($same_interp, \&GET, $location);
> >      $skip++ unless defined $received;
> >      skip_not_same_interp(
>
>
> what was the error message/failure? it works fine for me w/o the patch.

Well, I can guess that you were getting the same results as the 1st 
sub-test. In which case it doesn't reload the file. Try plaing with this 
function:

sub touch_mtime {
    my $file = shift;
    # push the mtime into the future (at least 2 secs to work on win32)
    # so Apache::Reload will reload the package
    my $time = time + 5; # make it 5 to be sure
    utime $time, $time, $file;
}

may be you need to change 5 to some much bigger value?

Enable 'PerlSetVar ReloadDebug On' on the server side file (and return 
t/TEST -conf) to see whether it doesn't get reloaded (I think it doesn't).

--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxxxxxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com