Re: [mp2 rfc] APR::Bucket new methods

Philippe M. Chiasson wrote:

> >    for (my $b = $bb->first; $b; $b = $bb->next($b)) {
> >
> >        last if $b->is_eos;
> >
> >        if ($b->read(my $data)) {
> >            $b->replace_data(APR::Bucket->new(uc $data));
> >        }
> >    }
>
>
> You must have meant : $b->replace_data(uc $data) right ?

Yes, thank you :)

> > BTW, the streaming API is buggy, since it loses any meta buckets, but 
> > EOS. e.g. in the above example, if an upstream filter has sent a FLUSH 
> > bucket, it'll get lost, rendering a filter that uses the streaming API 
> > as in improperly behaved one.
>
>
> Any particular reason it's losing those buckets that we can't address/fix ?

Not in the way the API is designed. The streaming API was designed to get 
the data out, think of it as $bb->flatten but a bit more effective, as it 
gets in chunks. Only later the check for eos was added. So there is no way 
to tell whether there was a flush bucket for example. And even if we could 
somehow handle that, what about other meta buckets? I think the streaming 
API shouldn't be used in things like CPAN modules, but is good for quick 
prototyping or in-house projects where you know exactly what other filters 
are being used and whether or not you care about losing those other 
buckets or not.

--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxxxxxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com