Re: mod_perl2 1.99_14 and httpd 2.0.49 - gmake test fails (cannot start apache)

Randy Kobes wrote:

> Index: Apache-Test/lib/Apache/TestSSLCA.pm
> ===================================================================
> RCS file: 
> /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestSSLCA.pm,v
> retrieving revision 1.18
> diff -u -r1.18 TestSSLCA.pm
> --- Apache-Test/lib/Apache/TestSSLCA.pm 4 Mar 2004 05:51:31 -0000       1.18
> +++ Apache-Test/lib/Apache/TestSSLCA.pm 25 Jul 2004 15:25:19 -0000
> @@ -166,8 +166,8 @@
>      my $cmd = "$openssl @_";
>  
>      info $cmd;
> -
> -    unless (system($cmd) == 0) {
> +    my @args = split ' ', $cmd;
> +    unless (system(@args) == 0) {
>          my $status = $? >> 8;
>          die "system @_ failed (exit status=$status)";
>      }

I suppose that this was not a part of the patch :) And if it is it's a 
no go, since it'll break an argument with embedded spaces, like "this is 
a single argument" :)

--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxxxxxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com