Re: Trying to test current apreq2 CVS

doh! I forgot to send it :)

Randy Kobes wrote:
> On Wed, 14 Jul 2004, Stas Bekman wrote:
>
>
> > Markus Wichitill wrote:
> >
> > > > Adding MP_AP_PREFIX/bin
> > > > to your PATH is the simplest approach to this (I'll have
> > > > to see about doing this automatically for the tests).
> > >
> > > How about this?
> >
> > I'm not sure what is it for, too much context removed, but
> > I guess Randy knows what is it about.
>
>
> It comes about because, when running the tests, Apache
> may need certain external dlls in the Apache bin/ directory.
> The PATH is used to search for these dlls.

Sure :)

> What about the following?
> ======================================================
> Index: Makefile.PL
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/Makefile.PL,v
> retrieving revision 1.143
> diff -u -r1.143 Makefile.PL
> --- Makefile.PL 5 Jul 2004 22:02:42 -0000       1.143
> +++ Makefile.PL 15 Jul 2004 01:22:50 -0000
> @@ -598,8 +598,13 @@
>  sub MY::test {
>
>      my $env = Apache::TestConfig->passenv_makestr();
> +    my $ap_bindir = File::Spec->catdir($build->{MP_AP_PREFIX}, 'bin');

If you are sure that that's always be the case then, that's fine, but it 
should be done explicitly for windows then. Since this could be totally 
incorrect in the general case should we try to use $ap_bindir later on. 
So I'd rather see:

    my $preamble;
    if (Apache::TestConfig::WIN32) {
        my $ap_bindir = File::Spec->catdir($build->{MP_AP_PREFIX}, 'bin');
        $preamble = <<EOF;
PATH = \$(PATH);$ap_bindir
EOF
    }
    else {
        my $env = Apache::TestConfig->passenv_makestr();
        $preamble = <<EOF;
PASSENV = $env
EOF
    }

BTW, env is not needed for win32?


--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxxxxxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com