Re: Trying to test current apreq2 CVS

On Thu, 15 Jul 2004, Markus Wichitill wrote:

> > It comes about because, when running the tests, Apache
> > may need certain external dlls in the Apache bin/ directory.
> > The PATH is used to search for these dlls.
>
> > What about the following?
> > +    my $ap_bindir = File::Spec->catdir($build->{MP_AP_PREFIX}, 'bin');
>
> That doesn't work with "perl Makefile.PL
> MP_APXS=blah\apache2\bin\apxs.bat", that's why I used
> $build->apr_bindir().
>
> If this is about APR possibly being installed outside of the Apache
> directory (?), I guess we have to include both paths.

No, I wasn't thinking of that possibility; I just thought
MP_AP_PREFIX would be simpler, but I forgot about using
MP_APXS instead. What about the following - it tries
both, and if neither are defined, it give up.
===============================================================
Index: Makefile.PL
===================================================================
RCS file: /home/cvs/modperl-2.0/Makefile.PL,v
retrieving revision 1.143
diff -u -r1.143 Makefile.PL
--- Makefile.PL 5 Jul 2004 22:02:42 -0000       1.143
+++ Makefile.PL 15 Jul 2004 03:56:21 -0000
@@ -598,8 +598,17 @@
 sub MY::test {

     my $env = Apache::TestConfig->passenv_makestr();
+    my $ap_bindir = $build->apr_bindir();
+    if (! $ap_bindir) {
+        $ap_bindir = $build->{MP_AP_PREFIX} ?
+        File::Spec->catdir($build->{MP_AP_PREFIX}, 'bin') : '';
+    }

-    my $preamble = Apache::TestConfig::WIN32 ? "" : <<EOF;
+    my $preamble = Apache::TestConfig::WIN32
+        ? <<EOF
+PATH = \$(PATH);$ap_bindir
+EOF
+        : <<EOF;
 PASSENV = $env
 EOF

===============================================================

-- 
best regards,
randy