Re: [Patch mp2] Deprecate $Apache::Server::StrictPerlSections in favor of a default of 1

Philippe M. Chiasson wrote:
> Unless I am seriously mistaken, the consensus was to completely get rid 
> of configurable
> strictness for perlsections. Fix it at strict, and suggest using eval {} 
> blocks if there
> is a need _not_ to abort server-startup in the case of an exception.

+1 with a few non-code related comments.

> Index: Changes
> ===================================================================
> RCS file: /home/cvs/modperl-2.0/Changes,v
> retrieving revision 1.409
> diff -u -I$Id -r1.409 Changes
> --- Changes    12 Jul 2004 23:16:21 -0000    1.409
> +++ Changes    13 Jul 2004 00:45:27 -0000
> @@ -12,6 +12,10 @@
>
>  =item 1.99_15-dev
>
> +Deprecate $Apache::Server::StrictPerlSections. Now, all <Perl>
> +sections are strict by default and cause server startup to
> +abort on error. [Gozer]

not deprecated, but removed.

> Index: docs/user/porting/compat.pod
> ===================================================================
> RCS file: /home/cvs/modperl-docs/src/docs/2.0/user/porting/compat.pod,v
> retrieving revision 1.55
> diff -u -I$Id -r1.55 compat.pod
> --- docs/user/porting/compat.pod    7 Jul 2004 21:52:25 -0000    1.55
> +++ docs/user/porting/compat.pod    13 Jul 2004 00:45:27 -0000
> @@ -84,6 +84,13 @@
>        PerlFreshRestart
>    </IfDefine>
>
> +=head2 C<$Apache::Server::StrictPerlSections>
> +
> +In mod_perl 2.0, C<L<E<lt>PerlE<gt>|docs::2.0::api::Apache::PerlSections>>
> +sections are now always strict. Any error in them will cause an immediate

s/strict/fatal/. You may want to add a comment that 'strict' was a 
misnomer in mp1.

> +server startup abort, dumping the error to stderr. To avoid this, eval 
> blocks
> +can be used to trap errors and ignore them.

there is no 'blocks', better: s/eval blocks/C<eval {}>/


--
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxxxxxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com