Re: [mp2] recent 5.6.x breakage

On Wed, 30 Jun 2004, Stas Bekman wrote:

> Randy Kobes wrote:
[ .. ]
> > I think the difference is is that I installed
> > ExtUtils::Embed from the perl-5.8.4 distribution, and it's
> > marked as version 1.2506_01, which being a development
> > version, doesn't show up on CPAN.pm.
>
> It's not about us, but users who won't have that version in any case.

That's true - I was just wondering if it was a problem
(that's been fixed) with the older ExtUtils::Embed, or
something else.

> >>Though I can't quite figure out how that objects becomes
> >>an argument to catdir.
> >
> >
> > Another thing that occurred to me - with the recent
> > APR/mod_perl.so decoupling, a warning comes up at the 'perl
> > Makefile.PL' stage concerning MY::postamble being redefined
> > from xs/APR/APR/Makefile.PL and xs/APR/aprext/Makefile.PL.
> > Might this be at all related?
>
> Yes, I've mentioned that issue when I posted my original
> patch. I've spent some time trying to get rid of it, but
> in vain. I'll try again today. It might be releated.

Although this doesn't solve the basic problem of getting rid
of the warnings in general, does the following help? It just
copies the relevant files via File::Copy, rather than doing
so via Makefile - it would at least show if the problem
arises because of the MY::postamble redefinitions.
==========================================================
Index: xs/APR/APR/Makefile.PL
===================================================================
RCS file: /home/cvs/modperl-2.0/xs/APR/APR/Makefile.PL,v
retrieving revision 1.23
diff -u -r1.23 Makefile.PL
--- xs/APR/APR/Makefile.PL      28 Jun 2004 02:10:02 -0000      1.23
+++ xs/APR/APR/Makefile.PL      30 Jun 2004 18:17:46 -0000
@@ -7,6 +7,7 @@
 use Apache::Build ();
 use Config;
 use File::Spec::Functions;
+use File::Copy;

 use constant WIN32   => Apache::Build::WIN32;
 use constant SOLARIS => $^O eq 'solaris';
@@ -72,19 +73,11 @@
     push @clean, $cfile;
     $src{$cfile} = "$srcdir/$cfile";
 }
+for (keys %src) {
+    copy($src{$_}, '.') or die "Cannot copy $_: $!";
+}

 $args{OBJECT} = WIN32 ? "APR.o" : "APR.o @obj";
 $args{clean}  = { FILES => "@clean" };

 ModPerl::BuildMM::WriteMakefile(%args);
-
-sub MY::postamble {
-    my $self = shift;
-    my $string = $self->ModPerl::BuildMM::MY::postamble;
-
-    $string .= join '', map {
-        "$_: $src{$_}\n\t\$(CP) $src{$_} .\n";
-    } keys %src;
-
-    return $string;
-}
Index: xs/APR/aprext/Makefile.PL
===================================================================
RCS file: /home/cvs/modperl-2.0/xs/APR/aprext/Makefile.PL,v
retrieving revision 1.2
diff -u -r1.2 Makefile.PL
--- xs/APR/aprext/Makefile.PL   28 Jun 2004 02:10:02 -0000      1.2
+++ xs/APR/aprext/Makefile.PL   30 Jun 2004 18:17:46 -0000
@@ -16,6 +16,12 @@
     push @clean, $cfile;
     $src{$cfile} = "$srcdir/$cfile";
 }
+if(Apache::Build::WIN32) {
+    require File::Copy;
+    for (keys %src) {
+        File::Copy::copy($src{$_}, '.') or die "Cannot copy $_: $!";
+    }
+}

 my @skip = qw(dynamic test);
 push @skip, q{static} unless Apache::Build::WIN32;
@@ -29,13 +35,3 @@
           );

 ModPerl::BuildMM::WriteMakefile(%args);
-
-sub MY::postamble {
-    my $self = shift;
-    my $string = $self->ModPerl::BuildMM::MY::postamble;
-
-    $string .= join '', map {
-        "$_: $src{$_}\n\t\$(CP) $src{$_} .\n";
-    } keys %src;
-    return $string;
-}

============================================================

-- 
best regards,
randy