logo       
Google Custom Search
    AddThis Social Bookmark Button
-->

Re: [mp2 filters] allocating modperl_wbucket_t or not: msg#00102

Subject: Re: [mp2 filters] allocating modperl_wbucket_t or not

Stas Bekman wrote:
> Currently we allocate a wbucket of type modperl_wbucket_t for each
> filter invocation. If it's not a streaming filter (i.e. manipulates
> bucket brigades or doesn't use read/print) it's never going to need
> wbucket. wbucket consumes 16404 bytes, the filter struct without
> wbucket consumes 60 bytes. In order not to penalize non-streaming
> filters, I suggest not to allocate wbucket if and not until it's first
> used.

you're still way ahead of the game here, so go with what you think is best
(thanks for asking, though :)

if you have the time and can explain what a wbucket is, that would be great,
too :)

--Geoff


<Prev in Thread] Current Thread [Next in Thread>