Re: RE : RE : bug : make test fails

Barbara Post wrote:
> OK, sorry for the offense, you're right.

It wasn't an offense at all, sorry if I sounded like it was...

> The answer of the perl command line is an empty string.
>
> $ perl -Mlib=Apache-Test/lib -MApache::TestRequest -le 'print
> Apache::TestRequest::has_lwp'

Thanks Barbara. I just wanted to double check that it didn't think that it had 
LWP installed when it didn't. For some reason I can't reproduce the problem.

> I will install LWP on Monday then.

Before you do that, can you please try applying this patch and see if it's 
still broken. I think it should work now fine without LWP:

Index: Apache-Test/lib/Apache/TestServer.pm
===================================================================
RCS file: 
/home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestServer.pm,v
retrieving revision 1.73
diff -u -r1.73 TestServer.pm
--- Apache-Test/lib/Apache/TestServer.pm        24 Nov 2003 08:28:34 -0000      
1.73
+++ Apache-Test/lib/Apache/TestServer.pm        30 Nov 2003 20:57:57 -0000
@@ -584,10 +584,9 @@

     my $server_up = sub {
         local $SIG{__WARN__} = sub {}; #avoid "cannot connect ..." warnings
-        if (my $r = Apache::TestRequest::GET('/index.html')) {
-            return $r->code;
-        }
-        0;
+        # avoid fatal errors
+        my $r = eval { Apache::TestRequest::GET('/index.html') };
+        return !$@ && defined $r ? $r->code : 0;
     };

     if ($server_up->()) {



__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxxxxxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com