Re: [patch] shutting down 'constant sub redefined' in Apache::Reload

Stas Bekman wrote:
> Philippe M. Chiasson wrote:

> > >              no warnings FATAL => 'all';
> > > +            local $SIG{__WARN__} = \&skip_redefine_const_sub_warn
> > > +                if $NoWarningsConstantRedefine;
> > >              require $key;
> > >              warn("Apache::Reload: process $$ reloading $key\n")
> > >                      if $DEBUG;
> > > @@ -149,6 +154,11 @@
> > >      }
> > >
> > >      return Apache::OK;
> > > +}
> > > +
> > > +sub skip_redefine_const_sub_warn {
> > > +    return if $_[0] =~ /^Constant subroutine [\w:]+ redefined at/;
> > > +    CORE::warn(@_);
> > >  }
> > >
> > >  1;
> >
> >
> > I am not sure about this one, but I would say that this will cut the
> > grass from under the feet of a module that installed his/her own
> > SIG{__WARN__} handler, won't it ?
>
>
> it sure would. Messing with SIG{__(WARN|DIE)__} is always a bad idea if 
> it's not under your control.

Actually it won't. if the module defines its own $SIG{__WARN__} it will 
override Apache::Reload's one, but that's fine, since the module will be 
reloaded by that time.



__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxxxxxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com