Re: [patch] Apache->server->pool

Geoffrey Young wrote:
> > Oops, that's a bad copy-n-paste, should be:
> >
> >   $s->process->pool->cleanup_register(\&cleanup_callback, $data);
>
>
> ok, that works.  well, sort of.  I can make the call but the code 
> (again) never runs.  have you tried it?

I meant to use $s->process->pool to get the pool. I didn't do any claims about 
cleanup_register() on server working ;)

> > > anyway, here is a patch that seems to fit the bill.  well, almost.  
> > > it implements Apache->server->pool(), which you can now use to 
> > > register cleanups via Apache->server->pool->cleanup_register().  all 
> > > tests pass.
> >
> > $s->process->pool is not good? (agreed that it's not very intuitive, 
> > but that's where it lives in the apache structs.)
>
>
> outside of its not working, that's fine.  a little less intuitive, yes, 
> but no biggie.  

$s->process->pool is working. The cleanup registration is not. It's not the 
same. My question was whether we need to have an alias so we can get $s->pool 
do $s->process->pool.

> actually, now that I know this,
>
> $s->process->pconf->cleanup_register()

yup, the main pool.

> is really what I was after, since I want to capture configuration -HUP 
> changes.  it's nice that process_rec gives you that kind of 
> granularity.  cool.

Cool.

> > and the modperl_child_exit function in the same file. Notice how the 
> > child_exit is executed and that the pool is cleared only if destruct 
> > level is set.
>
>
> cool :)
>
> > I suppose what you should do instead is:
> >
> >   $s->push_handlers(PerlChildExitHandler => 'my_cleanup');
>
>
> well, that's not exactly the same.  in 1.0 $s->register_cleanup() called 
> the sub on server exits or restarts - that's what I'm looking to 
> duplicate here.
>
> at any rate, it looks like process->pool() and process->pconf() will fit 
> the bill... if only they actually worked :)

So this part probably needs work.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxxxxxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com