Re: cvs commit: modperl-2.0/t/response/TestDirective perlrequire.pm

Randy Kobes wrote:
> On Wed, 16 Apr 2003, Stas Bekman wrote:
>
>
> > ah, no, scratch that. This module is confusing... it provides
> > special functionality when perl is built w/ perlio layers.
> > However it provides another important C-level functionality
> > which doesn't require perlio layers (an example of use is in
> > Apache::Subprocess). The attached patch should probably skip OK
> > on win32.
> >
> > Randy, when you will get a chance can you please check why we
> > special-case win32? it has to work on win32 too. See
> > xs/APR/PerlIO/apr_perlio.c. Thanks!
>
>
> I think it has to do with the comment in lib/ModPerl/BuildMM.pm,
> in the ModPerl::BuildMM::MY::libscan sub, about APR::PerlIO not
> linking on Win32. I just checked that and it's still the case -
> there's a missing symbol that doesn't appear in perl58.lib.

The reason is most likely the fact that .def is not created with the right 
symbols. (the same problem for aix with .exp)

> > Index: t/response/TestAPR/perlio.pm
> > ===================================================================
> > RCS file: /home/cvs/modperl-2.0/t/response/TestAPR/perlio.pm,v
> > retrieving revision 1.17
> > diff -u -r1.17 perlio.pm
> > --- t/response/TestAPR/perlio.pm        8 Apr 2003 02:05:34 -0000       1.17
> > +++ t/response/TestAPR/perlio.pm        16 Apr 2003 05:21:25 -0000
> > @@ -23,11 +23,15 @@
> >
> >      $tests += $lfs_tests unless LARGE_FILES_CONFLICT;
> >
> > -    eval { require APR::PerlIO };
> > +    # 1) APR::PerlIO is not available on all platforms
> > +    # 2) on those platforms where available,
> > +    #    PerlIO-enabled perl is needed to run this test
> > +    my $run = eval { require APR::PerlIO } &&
> > +        APR::PerlIO::PERLIO_LAYERS_ARE_ENABLED()
> > +            ? 1
> > +            : have  { "This Perl build doesn't support PerlIO layers" => 0 };
> >
> > -    plan $r, tests => $tests, have {
> > -        "This Perl build doesn't support PerlIO layers" =>
> > -            APR::PerlIO::PERLIO_LAYERS_ARE_ENABLED() };
> > +    plan $r, tests => $tests, $run;
>
>
> Does the following make sense? If I run 'nmake test', then (with
> the above patch) all 11 perlio tests are reported as fails. If I
> run perlio individually, then the perlio tests are (occasionally)
> skipped, with the message indicated above appearing, but at other
> times, an error is (sometimes) reported that an undefined routine
> APR::PerlIO::PERLIO_LAYERS_ARE_ENABLED() was called.
>
> Incidentally, the apache/subprocess.t test is skipped
> consistently, with a report that it can't find APR::PerlIO.
>
> Other than this, the rest of the tests pass.
>
> I'm confused, and it's late ....

apache/subprocess.t needs to call APR::PerlIO::PERLIO_LAYERS_ARE_ENABLED() 
only for certain functionality, so we just test whether APR::PerlIO is available:

    plan $r, tests => 4, have qw(APR::PerlIO Apache::SubProcess);

Strange that the committed change still doesn't work :( Can you try this one:

    my $run = have 'APR::PerlIO' &&
        have { "This Perl build doesn't support PerlIO layers" =>
                    APR::PerlIO::PERLIO_LAYERS_ARE_ENABLED() };
    plan $r, tests => $tests, $run;

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxxxxxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com