Re: cvs commit: modperl-2.0/t/response/TestDirective perlrequire.pm

Randy Kobes wrote:
> On Wed, 16 Apr 2003, Stas Bekman wrote:
>
>
> > stas@xxxxxxxxxx wrote:
> >
> > > stas        2003/04/15 20:33:42
> > >
> > >  Modified:    t/response/TestDirective perlrequire.pm
> > >  Log:
> > >  don't load the whole startup file in the perlrequire's
> > >  vhost, just adjust @INC so it can find all the needed things
> > >  
> >
> > Most likely the cause of the problem you have reported, Randy,
> > was the add_config, but the one running from within a vhost. We
> > had modperl_extra.pl executed second time from the vhost
> > running perlrequire tests. I've changed it not to load the
> > whole file, but just the needed bits.
> >
> > Certainly it doesn't solve the problem, but I'm devising a
> > separate test to test just add_config in the vhost. I just want
> > to have the test suite work 100% and have the 1.99_09 release
> > out of the door asap.
> >
> > Please let me know what is the status on win32 with the current
> > mod_perl cvs.
>
>
> Right again! This does avoid the crash ... 

Great!

> The other problems
> with the tests that I had mentioned earlier have also now been
> fixed with this, except for apr/perlio, which gets a 500
> response. I believe this was skipped in earlier versions, due to
> not having APR::PerlIO?

Correct. What's the error_log says?

It still should be skipped. I've messed with the skip rules a bit lately, 
since it was skipping on the platforms that did have APR::PerlIO working.

The module is always available, though it won't boot if perlio_layers aren't 
available. So I though that this will work:

    eval { require APR::PerlIO };

    plan $r, tests => $tests, have {
        "This Perl build doesn't support PerlIO layers" =>
            APR::PerlIO::PERLIO_LAYERS_ARE_ENABLED() };

APR::PerlIO::PERLIO_LAYERS_ARE_ENABLED is defined in APR/PerlIO.pm. For some 
reason I thought that even though the module fails to boot its XS layer its 
perl functions would be available.

If you apply this patch, does it skips OK:

Index: t/response/TestAPR/perlio.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/t/response/TestAPR/perlio.pm,v
retrieving revision 1.17
diff -u -r1.17 perlio.pm
--- t/response/TestAPR/perlio.pm        8 Apr 2003 02:05:34 -0000       1.17
+++ t/response/TestAPR/perlio.pm        16 Apr 2003 04:48:54 -0000
@@ -15,6 +15,8 @@
 #XXX: you can set to zero if largefile support is not enabled in Perl
 use constant LARGE_FILES_CONFLICT => 1;

+use Config;
+
 sub handler {
     my $r = shift;

@@ -23,11 +25,11 @@

     $tests += $lfs_tests unless LARGE_FILES_CONFLICT;

-    eval { require APR::PerlIO };
-
     plan $r, tests => $tests, have {
         "This Perl build doesn't support PerlIO layers" =>
-            APR::PerlIO::PERLIO_LAYERS_ARE_ENABLED() };
+            ($Config{useperlio} && $] >= 5.00703) };
+
+    require APR::PerlIO;

     my $vars = Apache::Test::config()->{vars};
     my $dir  = catfile $vars->{documentroot}, "perlio";


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxxxxxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com