Re: [patch] filter_init implementation

Geoffrey Young wrote:
> > Hmm, I'm puzzled how did it work for me at all! The filter handler was 
> > bogus. Do you still have a segfault if you replace it with:
>
>
> yes, that worked.  nice.

Great!

>  >> FilterPreHandler?  it's really preprocessing that is going on here, so
>  >> maybe that's more descriptive than anything 'init' based.  I agree now
>  >> more than ever that filter_init is a really bad name, and will have
>  >> misleading connotations for Perl developers, who expect different
>  >> things from initialization routines :)
>  >
>  > Sounds fine with me. So we do design a new phase missing from Apache ;)
>  > Those who want to do filter initialization can use $f->ctx.
>  >
>  > The question still stands. Do we want:
>  >
>  > sub init {}
>  > sub filt : FilterRequestHandler FilterPreHandler(init)  {}
>  >
>  > or
>  >
>  > sub init : FilterPreHandler {}
>  > sub filt : FilterRequestHandler FilterNeedsPreHandler(init) {}
>
> the first seems to make the most sense to me - I don't see why we need 
> to make the pre handler take an attribute only to create another 
> attribute to run it.

Well, I agree with you. It's just that I don't feel very happy about 
linguistics. Currently attributes indentify the properties of the filters. 
FilterPreHandler(init) has nothing to do with the real filter, other than 
creating a dependency. But I guess it's just a matter of getting used to it. 
However if you see what I mean, won't FilterRunsPreHandler(init) sound more 
like a property:

sub filt : FilterRequestHandler FilterRunsPreHandler(init) {}

So in English we can say that filter 'filt' is a request filter handler that 
runs prehandler 'init'.

Whereas FilterPreHandler can thought as being the prehandler.

See what I mean?

Also:

sub init : FilterPreHandler {}

makes it sure that that sub won't be used in any other way, than designed. But 
that could be redundant I suppose.

>  > Anyways, I've changed a bit the expectations and the response handler
>  > and voila, it works ;)
>  >
>  > the new version is attached.
>
> ah, cool.  the output filter test worked too.
>
> I'd say commit all this stuff - we certainly have enough to work with 
> now, and we can build on it as we go.

Looking forward to see your conditional GET tests and may be other interesting 
apps.

> very nice work, stas.

;)

I still have to complete the source parsing to support fully blown perl code 
as an argument to FilterPreHandler().

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxxxxxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com