whoops, I snipped the other stuff by accident :)
I was thinking about having the env vars set in the startup file. So
later on you just have to set MOD_PERL=2 or MOD_PERL=1.
So I do propose to change Apache::Test to use:
APXS APACHE APACHE_GROUP APACHE_USER APACHE_PORT
when it detects mod_perl 1.0 and to use:
APXS2 APACHE2 APACHE2_GROUP APACHE2_USER APACHE2_PORT
when it detects mod_perl 2.0.
ok, you've sold me :)
I think that since we have a casted in stone $ENV{MOD_PERL}, we should
stick with the underscore everywhere else.
For XS code we have used -DMOD_PERL, my question is whether we should
have -DMOD_PERL2 or -DMOD_PERL=2
it doesn't matter to me, and I suspect it will be transparent to most
anyway.
--Geoff
|
