Re: [patch] Apache2->unimport

Geoffrey Young wrote:
> Stas Bekman wrote:
>
> > I was thinking that some modules will need to make sure not to pick 
> > 2.0 modules, when they work in 1.0 mode (e.g. Apache::Test), because 
> > if Apache2 is inadvertenly loaded the wrong module versions will be 
> > picked. 
>
>
> is this really an issue?  I mean, if you're using 2.0 and you use 
> Apache2 then you're ok.  if you're using 1.0 then Apache2 isn't an 
> option (it's not available) so you still find the right libraries.  even 
> something like Apache::Filter seems to be ok here - if you load Apache2 
> then it checks Apache2/ first, picking up the right version, whereas in 
> 1.0 it doesn't check Apache2/ at all.
>
> at first I thought you were right, and I was going to suggest porting 
> Apache2 (with unimport) to 1.0.  then I thought about what circumstances 
> someone in 1.0 would want to use it and couldn't see the validity - 1.0 
> works just fine, and the Apache2 trick was born exactly so 1.0 would 
> continue to work without intervention.

Agreed, but read on.

> > e.g. Apache::Test may pick up httpd-2 as the default if it succeeds to 
> > require Apache::Build.
>
>
> that sounds like a bug.  personally, I'm really irked by any 2.0 
> defaults in Apache::Test.  I've been using it for 1.0, well, since it 
> was made available and it's works very nicely there, but to have people 
> always assume I'm talking about 2.0 (Apache or mod_perl) is really 
> annoying - it should really be a generic test platform.

That's exactly why I was thinking about unimport, because Apache::Test 
shouldn't be able to find 2.0 stuff if Apache2 wasn't loaded (assuming that 
both modperls are installed), but it does find it. I'm going to try to rectify 
this problem.

I think Apache::Test should load mod_perl.pm, look at the version and act 
accordingly.

Back to the issue, let's stay without unimport and announce it a bug if 
Apache2 was loaded when mod_perl 1.0 is used and trace who loaded it and fix 
the bug.

<unrelated>
Unfortunately, mod_perl 1 doesn't provide any information about location of 
the apxs/httpd executables, so we have to rely on $ENV{APACHE} or explicit 
specification of httpd's location or a prompt. We no longer can do any 
guessing because we may pick a wrong version of httpd.
</unrelated>

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxxxxxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com