Re: [VOTE][PATCH]updates on forward only resultset using JDBC 2.0 UpdatableResultset APIs

On Mon, 21 Feb 2005 11:58:36 -0800, Mamta Satoor 
<msatoor-Re5JQEeQqe8AvxtiuMwx3w@xxxxxxxxxxxxxxxx> wrote:
> Hi,
> 
> I have addressed the comments made by Dan for performance. Here is the
> new patch. Let me know what you all think.
> 
> The comments made by Dan can be found in following thread
> http://mail-archives.eu.apache.org/mod_mbox/db-derby-dev/200502.mbox/%3c42093858.C08AB984-+093KqXbTgTk/NM4vaOc/w@xxxxxxxxxxxxxxxx%3e
> 
> I have run all the tests and they ran fine.
> 
> svn stat output
> M      java\engine\org\apache\derby\impl\jdbc\EmbedResultSet.java
> M      java\engine\org\apache\derby\impl\jdbc\EmbedDatabaseMetaData.java
> M      java\engine\org\apache\derby\impl\jdbc\EmbedResultSet20.java
> M      java\engine\org\apache\derby\iapi\types\SQLClob.java
> M      java\engine\org\apache\derby\iapi\reference\SQLState.java
> M      java\engine\org\apache\derby\loc\messages_en.properties
> M      java\testing\org\apache\derbyTesting\functionTests\tests\lang\build.xml
> M      
> java\testing\org\apache\derbyTesting\functionTests\tests\lang\updatableResultSet.java
> M      
> java\testing\org\apache\derbyTesting\functionTests\tests\jdbcapi\resultsetJdbc30.java
> M      
> java\testing\org\apache\derbyTesting\functionTests\master\resultsetJdbc30.out
> M      
> java\testing\org\apache\derbyTesting\functionTests\master\parameterMapping.out
> M      
> java\testing\org\apache\derbyTesting\functionTests\master\updatableResultSet.out
> A      java\testing\org\apache\derbyTesting\functionTests\master\jdk14
> A      
> java\testing\org\apache\derbyTesting\functionTests\master\jdk14\updatableResultSet.out
> 
> thanks,
> Mamta
> 
> 
> 


I wondered if anyone had any comments on this patch?

thanks,
Mamta