Re: [PATCH] auto-generate apr.dsp and libapr.dsp files

Branko Čibej wrote:
> Garrett Rooney wrote:
>
> > +def win32ify_paths(paths):
> > +  rpaths = []
> >
> > +  for p in paths:
> > +    segs = re.split('/', p)
> > +    rp = '.\\' + string.join(segs, '\\')
> > +    rpaths.append(rp)
> > +
> > +  return rpaths
> >  
> Hmmm....
>
>    def win32ify_paths(paths):
>        return map(lambda x: '.\\'+string.replace(x, '/', '\\'), paths)
>
> Howzat? :-)

Hey, I never said I was good at python ;-)

> > +
> > +
> > +def do_windows(parser):
> > +  subdirs = []
> > +
> > +  for subdir in string.split(parser.get('options', 'platform_dirs')):
> > +    path = '%s/%s' % (subdir, 'win32')
> >  
> Why not
>
>    path = os.path.join(subdir, 'win32')?
>
> You do the win32ification later on anyway.

Yeah, that would make more sense...

> On the whole, it looks good. I'll give it a spin tomorrow. We can add 
> the file groups later on (they're not necessary, but they do make it 
> easier for the user).

Cool.

> Regarding the "lesser" dsps: I fully expect them to be generated later 
> on, because we'll want to be able to create VS.NET .vcproj files, too.

Oh, I agree, they should be generated as well, but one step at a time. 
I figured it was easier to build things out for the libs first, since 
that's all that's really needed for it to start to be useful, then move 
on to the rest of the build.

-garrett