osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] mod_deflate: hardcoded "%ld" -> APR_OFF_T_FMT


On Mon, Dec 17, 2018 at 5:40 PM William A Rowe Jr <wrowe@xxxxxxxxxxxxx> wrote:
>
> On Sun, Dec 16, 2018 at 7:27 AM Yann Ylavic <ylavic.dev@xxxxxxxxx> wrote:
>>
>>
>> Since it's logging only, it may be easier to cast to (long) each
>> total_in/out though.
>
> Downcast? Why not upcast to apr_off_t and use the _FMT macro as first suggested?

Neither is ideal I think since in the unsigned long case that's still
a cast to signed off_t.
But yes, upcast is better, while at it I'd go for uint64_t...