osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] mod_deflate: hardcoded "%ld" -> APR_OFF_T_FMT


On Sun, Dec 16, 2018 at 2:14 PM Stefan Sperling <stsp@xxxxxxxxxx> wrote:
>
> The file /usr/include/zlib.h I have on OpenBSD -current has this:
>
> typedef struct z_stream_s {
>     [...]
>     z_off_t  total_in;  /* total nb of input bytes read so far */
>     [...]
>     z_off_t  total_out; /* total nb of bytes output so far */
>     [...]
> } z_stream;

Ouch.

>
> This looks like an OpenBSD-specific change though (diff below).
> I guess this will force OpenBSD to carry a local patch for
> mod_deflate then, or just compile without -Werror.

I think we need a bit of #ifdef-ery in mod_deflate then, a BSD only
fix wouldn't help those who build from sources.

Do you know which BSD(s) are concerned (if not all)?