osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [VOTE] Release httpd-2.4.36


Am 11.10.2018 um 20:55 schrieb Ruediger Pluem:


On 10/11/2018 08:10 PM, Christophe JAILLET wrote:
No issue on my Ubuntu 18.04 VM.

On what configuration are you running your tests, Rüdiger? macOS, just like Jim?

Centos 7.5 64 Bit

Regards

Rüdiger

The test fails for me as well for 2.4.36 on SLES12. Small bodies are OK, large not. The limit is somewhere between 1.3 and 1.5 MB, not always the same. The test hangs there until mod_reqtimeout times out after a minute, complaining that it could not read more data from the client. If I reduce the multiplicator 1000000 to eg. 200000 it always passes.

If I start the test server using "t/TEST -start-httpd" and then use curl to POST data, I can even POST much bigger data and get the correct result back. I use

curl -v --data-binary @BIGFILE http://localhost:8529/apache/buffer_in/ > response-body

So I assume it is a problem of interaction between the server reading the POST body and the client sending it.

My test framework was freshly assembled recently, so lots of current modules.

The setup is based on OpenSSL 1.1.1 in the server and in the test framework, but the actual test runs over http, so I don't expect any OpenSSL related reason for the failure.

Regards,

Rainer

Le 11/10/2018 à 13:35, Jim Jagielski a écrit :
FWIW, on macOS, both trunk and httpd-2.4 fail on this test:

    t/modules/buffer.t .................. 3/12 # Failed test 4 in t/modules/buffer.t at line 32
    t/modules/buffer.t .................. 7/12 # Failed test 8 in t/modules/buffer.t at line 32 fail #2
    t/modules/buffer.t .................. 11/12 # Failed test 12 in t/modules/buffer.t at line 32 fail #3
    t/modules/buffer.t .................. Failed 3/12 subtests


On Oct 11, 2018, at 7:15 AM, Plüm, Rüdiger, Vodafone Group <ruediger.pluem@xxxxxxxxxxxx> wrote:

Do you know if the failure is a regression over 2.4.35?
   Regards
   Rüdiger
   Von: Marion et Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Gesendet: Donnerstag, 11. Oktober 2018 13:13
An: dev@xxxxxxxxxxxxxxxx
Betreff: re: AW: [VOTE] Release httpd-2.4.36
   Waouh!

This would mean I've provided a new useful test!

(it has been added recently in r1841508)

:)

I definitely need to document how to generate and use test-coverage data when running the test framework.

This helps to spot where new tests are needed.

CJ

Message du 11/10/18 10:08
De : "Plüm, Rüdiger, Vodafone Group" <ruediger.pluem@xxxxxxxxxxxx>
A : "dev@xxxxxxxxxxxxxxxx" <dev@xxxxxxxxxxxxxxxx>
Copie à :
Objet : AW: [VOTE] Release httpd-2.4.36

Anyone else seeing

t/modules/buffer.t (Wstat: 0 Tests: 12 Failed: 2)
Failed tests: 8, 12

?

I don't see this with trunk on the same machine. Issue seems to be if input filtering is on on large POSTs.

Regards

Rüdiger