][Date Next][Thread Prev
][Thread Next][Date Index
Re: svn commit: r1840265 - in /httpd/httpd/trunk: include/ap_mmn.h include/util_filter.h modules/http/http_request.c server/core_filters.c server/util_filter.c
On Fri, Sep 7, 2018 at 2:21 AM William A Rowe Jr <wrowe@xxxxxxxxxxxxx> wrote:
> I'd suggest you did a better job in the commit log explaning this than in the doxygen where it really is needed.
OK, I can do this when moving the declaration to a more private location.
> Private declares don't belong in util_filter.h IMO.
Agreed, actually I just discovered "server/core.h", sounds reasonable?
There probably are other "includes/" candidates, like:
Shouldn't we do something fot them too?