OSDir


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug in mod_ratelimit?


On Thu, Jul 19, 2018 at 8:23 PM, Luca Toscano <toscano.luca@xxxxxxxxx> wrote:
>
> Yann, any idea?

Looks like we missed the simplest case :/

Index: modules/filters/mod_ratelimit.c
===================================================================
--- modules/filters/mod_ratelimit.c    (revision 1835556)
+++ modules/filters/mod_ratelimit.c    (working copy)
@@ -208,7 +208,7 @@ rate_limit_filter(ap_filter_t *f, apr_bucket_briga
                     ap_remove_output_filter(f);
                 }
                 else if (!APR_BUCKET_IS_FLUSH(e)) {
-                    if (APR_BRIGADE_EMPTY(bb)) {
+                    if (ctx->do_sleep && APR_BRIGADE_EMPTY(bb)) {
                         /* Wait for more (or next call) */
                         break;
                     }
_