osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Brigade memory lifetime & leaks


On Tue, Jun 5, 2018 at 2:55 PM, Plüm, Rüdiger, Vodafone Group
<ruediger.pluem@xxxxxxxxxxxx> wrote:
>
>> -----Ursprüngliche Nachricht-----
>> Von: Joe Orton <jorton@xxxxxxxxxx>
>> Gesendet: Dienstag, 5. Juni 2018 14:48
>> An: dev@xxxxxxxxxxxxxxxx; dev@xxxxxxxxxxxxxx
>> Betreff: Re: Brigade memory lifetime & leaks
>>
>> We should remove apr_brigade_destroy() in APR 2, IMO, or switch to
>> bucket allocated brigades then.
>
> The question is whether we add them on top to the current ones or as a replacement.

As a replacement IMHO, the change could be documented as breaking
codes that dereference the brigade after the brigade_cleanup (the
pooled cleanup, not apr_brigade_cleanup!), but for APR-2 it's
reasonable, the API is much cleaner I think.


Regards,
Yann.