OSDir


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: svn commit: r1832716 - /httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.mak


+1 for cmake, looks like a few short lines to add but mak/dsp, it would just be simpler to copy /s .\modules\*.h .\include in a prebuild step of libhttpd and call it good. Otherwise with 111 modules in 2.4 that's 222 files that would need to be modified and would be overkill for some if not many.



On 6/2/2018 10:11 AM, William A Rowe Jr wrote:
Then let's put every modules/* directory /I into the list now across all
.mak/.dsp and cmakelists, just as the Unix build does? Then this should not
come up again until a new modules/Foo tree arrives?

WDYT?

On Sat, Jun 2, 2018, 12:01 Gregg Smith <gls@xxxxxxxx> wrote:

Well, assuming what your thinking of with OpenSSL is applink.c, that
challenge will be gone when 1.0.2 goes EOL. Libressl doesn't have
applink.c, yet, and carries with it its own challenges.

Aside from physically moving all headers to include/ in svn I don't see
this problem not popping up again sometime down the road unless you
happen to have a crystal ball.



On 6/1/2018 10:00 PM, William A Rowe Jr wrote:
Seems like another way to break the cmake build, this time, transitive
of needing modules/httpd2 from modules/proxy (still, borked).

Should we keep doing this, or move all of the includes into include/,
or create some openssl include/ symlink monstrosity, or, do we even
have a desire to fix this recurring issue?

Asking for a (group of several thousand) friend(s)...

On Fri, Jun 1, 2018 at 1:57 PM, <gsmith@xxxxxxxxxx> wrote:

Author: gsmith
Date: Fri Jun  1 18:57:21 2018
New Revision: 1832716

URL: http://svn.apache.org/viewvc?rev=1832716&view=rev
Log:
followup r1828485
needs mod_http2.h

Modified:
      httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.mak

Modified: httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.mak
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/
modules/proxy/mod_proxy.mak?rev=1832716&r1=1832715&r2=1832716&view=diff
============================================================
==================
--- httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.mak (original)
+++ httpd/httpd/branches/2.4.x/modules/proxy/mod_proxy.mak Fri Jun  1
18:57:21 2018
@@ -63,7 +63,7 @@ CLEAN :
       if not exist "$(OUTDIR)/$(NULL)" mkdir "$(OUTDIR)"

   CPP=cl.exe
-CPP_PROJ=/nologo /MD /W3 /Zi /O2 /Oy- /I "../ssl" /I "../../include" /I
"../../srclib/apr/include" /I "../../srclib/apr-util/include" /I
"../generators" /D "NDEBUG" /D "WIN32" /D "_WINDOWS" /D
"PROXY_DECLARE_EXPORT" /Fo"$(INTDIR)\\" /Fd"$(INTDIR)\mod_proxy_src"
/FD /c
+CPP_PROJ=/nologo /MD /W3 /Zi /O2 /Oy- /I "../ssl" /I "../../include" /I
"../../srclib/apr/include" /I "../../srclib/apr-util/include" /I
"../generators" /I "../http2" /D "NDEBUG" /D "WIN32" /D "_WINDOWS" /D
"PROXY_DECLARE_EXPORT" /Fo"$(INTDIR)\\" /Fd"$(INTDIR)\mod_proxy_src"
/FD /c

   .c{$(INTDIR)}.obj::
      $(CPP) @<<
@@ -169,7 +169,7 @@ CLEAN :
       if not exist "$(OUTDIR)/$(NULL)" mkdir "$(OUTDIR)"

   CPP=cl.exe
-CPP_PROJ=/nologo /MDd /W3 /Zi /Od /I "../ssl" /I "../../include" /I
"../../srclib/apr/include" /I "../../srclib/apr-util/include" /I
"../generators" /D "_DEBUG" /D "WIN32" /D "_WINDOWS" /D
"PROXY_DECLARE_EXPORT" /Fo"$(INTDIR)\\" /Fd"$(INTDIR)\mod_proxy_src" /FD
/EHsc /c
+CPP_PROJ=/nologo /MDd /W3 /Zi /Od /I "../ssl" /I "../../include" /I
"../../srclib/apr/include" /I "../../srclib/apr-util/include" /I
"../generators" /I "../http2" /D "_DEBUG" /D "WIN32" /D "_WINDOWS" /D
"PROXY_DECLARE_EXPORT" /Fo"$(INTDIR)\\" /Fd"$(INTDIR)\mod_proxy_src" /FD
/EHsc /c

   .c{$(INTDIR)}.obj::
      $(CPP) @<<