[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Question about RemoteIPInternalProxyList (PR 62220)


Hi Christophe,

responding here rather than in your latest "Bug 62220" thread because
it relates to your below debugging.

On Fri, Apr 6, 2018 at 9:56 PM, Marion et Christophe JAILLET
<christophe.jaillet@xxxxxxxxxx> wrote:
>
> Le 06/04/2018 à 20:23, Eric Covener a écrit :
>>
>> is it broken w/o vhosts? I am not sure cmd->server is right for
>> EXEC_ON_READ?  Maybe something in this neighborhood?
>
> at least the 'config' used in 'proxies_set()' is not the same when parsing
> RemoteIPInternalProxyList  and RemoteIPInternalProxy directives.
> And yes, according to my test, it seems to work without vhosts.

I tried to comment/disable remoteip_hook_pre_config() and got the same
server config for both directives.
Does it work better with the attached patch (not sure about the real
test to be done)?

Regards,
Yann.
Index: modules/metadata/mod_remoteip.c
===================================================================
--- modules/metadata/mod_remoteip.c	(revision 1832573)
+++ modules/metadata/mod_remoteip.c	(working copy)
@@ -492,6 +492,7 @@ static const char *remoteip_disable_networks(cmd_p
     return NULL;
 }
 
+#if 0
 static int remoteip_hook_pre_config(apr_pool_t *pconf, apr_pool_t *plog,
                               apr_pool_t *ptemp)
 {
@@ -502,6 +503,7 @@ static int remoteip_hook_pre_config(apr_pool_t *pc
 
     return OK;
 }
+#endif
 
 static int remoteip_hook_post_config(apr_pool_t *pconf, apr_pool_t *plog,
                                apr_pool_t *ptemp, server_rec *s)
@@ -1241,7 +1243,9 @@ static void register_hooks(apr_pool_t *p)
         ap_register_input_filter("REMOTEIP_INPUT", remoteip_input_filter, NULL,
                                  AP_FTYPE_CONNECTION + 7);
 
+#if 0
     ap_hook_pre_config(remoteip_hook_pre_config, NULL, NULL, APR_HOOK_MIDDLE);
+#endif
     ap_hook_post_config(remoteip_hook_post_config, NULL, NULL, APR_HOOK_MIDDLE);
     ap_hook_pre_connection(remoteip_hook_pre_connection, NULL, NULL, APR_HOOK_MIDDLE);
     ap_hook_post_read_request(remoteip_modify_request, NULL, NULL, APR_HOOK_FIRST);