[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug 62823] core_filter call mod_log_config before setting connec_rec to aborted


Ruediger Pluem <rpluem@xxxxxxxxxx> changed:

           What    |Removed                     |Added
                 OS|                            |All

--- Comment #1 from Ruediger Pluem <rpluem@xxxxxxxxxx> ---
(In reply to Arnaud Grandville from comment #0)
> I'm writing a module to translate http rest/json calls to pkcs11 protocol.
> I found a curious behavior, if the client gives up his request, whereas I
> use the %X flag is specified in my logFormat, the access log didn't report
> the request as cancelled with a "X".
> My module ends with several calls to ap_rwrite and return OK.
> But in server\core_filters.c when the brigade send fails the brigade is
> cleaned and request is logged before aborded status was updated
> ...
>         rv = send_brigade_blocking(net->client_socket, bb,
>                                    &(ctx->bytes_written), c);
>         if (rv != APR_SUCCESS) {
>             /* The client has aborted the connection */
>             ap_log_cerror(APLOG_MARK, APLOG_TRACE1, rv, c,
>                           "core_output_filter: writing data to the network");
>             apr_brigade_cleanup(bb);
>             c->aborted = 1;
>             return rv;
>         }
> ...
> would it not be necessary to update connection state before calling
> apr_brigade_cleanup ?

Is the problem fixed if you reverse the order of



c->aborted = 1;

You are receiving this mail because:
You are the assignee for the bug.
To unsubscribe, e-mail: bugs-unsubscribe@xxxxxxxxxxxxxxxx
For additional commands, e-mail: bugs-help@xxxxxxxxxxxxxxxx