[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug 48769] [PATCH] Processes in the busy list should not be killed during graceful restarts


https://bz.apache.org/bugzilla/show_bug.cgi?id=48769

Robert Mathews <rob-apachebugs@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34001|0                           |1
        is obsolete|                            |

--- Comment #11 from Robert Mathews <rob-apachebugs@xxxxxxxxxxxxx> ---
Created attachment 35944
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35944&action=edit
Remove "is mutex filename NULL" check

I found the cause of the leaked semaphores/shared memory in my comment #10.

When using mod_socache_shmcb, "fcgid_mutex_create(&g_sharelock,
&g_sharelock_name" will legitimately return NULL for g_sharelock_name. Because
of that, it's incorrect to check whether "g_sharelock_name == NULL" on a
graceful reload and then avoid reclaiming the previously created mutex.

I've attached a slightly modified version of the patch that avoids the
erroneous filename check in two places, and now there are no semaphore/shared
memory leaks.

I've been using this version of the patch with no trouble for a couple of weeks
on about 20 servers that have received hundreds of graceful restarts and tens
of millions of mod_fcgid requests. It completely fixes the original problem as
far as I can tell, and should be included in mod_fcgid.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@xxxxxxxxxxxxxxxx
For additional commands, e-mail: bugs-help@xxxxxxxxxxxxxxxx