osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug 61184] [PATCH] Fix build with LibreSSL in 2.4.26-dev


https://bz.apache.org/bugzilla/show_bug.cgi?id=61184

--- Comment #9 from Yann Ylavic <ylavic.dev@xxxxxxxxx> ---
(In reply to Bernard Spil from comment #8)
> 
> "next release of LibreSSL (2.6.x) will contain
> SSL_CTX_set_{min,max}_proto_version() and it is already available in
> -current."

So wouldn't somethig like:
    #if defined(LIBRESSL_VERSION_NUMBER) \
        && !defined(SSL_CTRL_SET_MIN/MAX_PROTO_VERSION)
or:     && !defined(SSL_CTX_set_min/max_proto_version)
be relevant right now?

Also, instead of:
    #if OPENSSL_VERSION_NUMBER < 0x10100000L \
        || defined(LIBRESSL_VERSION_NUMBER)
all over the place, couldn't we:
    #if OPENSSL_VERSION_NUMBER >= 0x10100000L \
        && !defined(LIBRESSL_VERSION_NUMBER)
    #define MODSSL_HAVE_SSL_1_1_API 1
    #endif
and test this instead (maybe with a better name)?


Thanks for the patch anyway! I plan to commit it but wanted your/team's
feedbacks on this change before.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@xxxxxxxxxxxxxxxx
For additional commands, e-mail: bugs-help@xxxxxxxxxxxxxxxx