OSDir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67073/
-----------------------------------------------------------

(Updated May 15, 2018, 11:18 p.m.)


Review request for hive, Peter Vary, Sahil Takiar, and Vihang Karajgaonkar.


Changes
-------

Changing the patch with new logic.
Adding an additional optional parameter dateFormat, which can provide output format that user expects.
The default format is kept as the existing one, YYYY-MM-dd. 
Hence, the patch is backward compatible, and also capable of handling different input and output formats as required by the user.

Also, now the code format is consistent with the other similar UDFs MonthsBetween and GenericUDFDateFormat.

Added unit tests to check various cases.

Thanks Peter for helping me reach a conclusion on what logic I need to use.

I have updated the UDF description. Will update the docs once the patch is approved.


Repository: hive-git


Description
-------

Adding support to retain the time part (HH:mm:ss) for add_months UDF when the input is given as timestamp format.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java dae4b97b4a17e98122431e5fda655fd9f873fdb5 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFAddMonths.java af9b6c43c7dafc69c4944eab02894786af306f35 


Diff: https://reviews.apache.org/r/67073/diff/2/

Changes: https://reviews.apache.org/r/67073/diff/1-2/


Testing
-------

Added unit tests.


Thanks,

Bharathkrishna Guruvayoor Murali