OSDir


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] jeanouii commented on issue #2: Upgrade to Eclipse Microprofile 1.1 and minor things


jeanouii commented on issue #2: Upgrade to Eclipse Microprofile 1.1 and minor things
URL: https://github.com/apache/geronimo-jwt-auth/pull/2#issuecomment-394116291
 
 
   Right.
   I’ll remove the toString too
   
   Le samedi 2 juin 2018, Romain Manni-Bucau <notifications@xxxxxxxxxx> a
   écrit :
   
   > *@rmannibucau* commented on this pull request.
   >
   > Wonder why tck coverage is reduced, otherwise except a minor not important
   > comment (on the tosteing which was coded for debug purposes) it is
   > mergeable IMHO
   > ------------------------------
   >
   > In geronimo-jwt-auth-impl/src/main/java/org/apache/geronimo/
   > microprofile/impl/jwtauth/cdi/GeronimoJwtAuthExtension.java
   > <https://github.com/apache/geronimo-jwt-auth/pull/2#discussion_r192568348>
   > :
   >
   > > @@ -397,7 +397,7 @@ public Claims standard() {
   >
   >          @Override
   >          public String toString() {
   > -            return super.toString().replace(", ", ", ");
   >
   > Why? If so then drop tostring ;)
   > ------------------------------
   >
   > In geronimo-jwt-auth-impl/src/test/resources/tck.xml
   > <https://github.com/apache/geronimo-jwt-auth/pull/2#discussion_r192568355>
   > :
   >
   > > @@ -40,8 +40,6 @@
   >        <class name="org.eclipse.microprofile.jwt.tck.container.jaxrs.ProviderInjectionTest" />
   >        <class name="org.eclipse.microprofile.jwt.tck.container.jaxrs.RolesAllowedTest" />
   >        <class name="org.eclipse.microprofile.jwt.tck.container.jaxrs.InvalidTokenTest" />
   > -      <class name="org.eclipse.microprofile.jwt.tck.container.jaxrs.PrimitiveInjectionTest" />
   >
   > Tck regression?
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/geronimo-jwt-auth/pull/2#pullrequestreview-125374791>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/ABLSQo9eu2qa6lmx7AuPTSQKUj1S30uZks5t4uosgaJpZM4UXuRc>
   > .
   >
   
   
   -- 
   Jean-Louis
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@xxxxxxxxxxxxxxxx


With regards,
Apache Git Services