OSDir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Import jwt auth code or do it back from scratch?


I think it's not about the work to do the import. It's just about that JL did all the work, so he should also show up as committer.
Merit to whom merit belongs to!

And ofc will help with reviews and polishing then!

LieGrue,
strub

> Am 03.04.2018 um 22:35 schrieb Romain Manni-Bucau <rmannibucau@xxxxxxxxx>:
> 
> 
> 
> Le 3 avr. 2018 21:37, "Jean-Louis MONTEIRO" <jeanouii@xxxxxxxxx> a écrit :
> Hi Romain,
> 
> Is there anything preventing to pull the code from my PR?
> 
> No, let me rephrase: can *you* import it please? :)
> 
> Not that I am very attached to the code I produced. 
> It's not perfect either, but wouldn't it be sad to start from scratch?
> 
> Jean-Louis
> 
> 
> 
> Le sam. 31 mars 2018 à 18:15, Romain Manni-Bucau <rmannibucau@xxxxxxxxx> a écrit :
> Hi JL
> 
> Is it ok for you to import the reusable code you did in the repo we got for the spec or do you prefer i recode it to populate the repo? Also planning to do the api jar next to the impl.
> 
> Thanks
>