[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [VOTE] XBean 4.7 release

The notice file appears to have been introduced to deal with a deficiency tracked as Jira issue XBEAN-283.


My vote: +1

We can review the merits of that issue separately and if it turns out that it is decided to be redundant to have the notice file - we can note it and remove the file later.

I don't think that it is necessary to hold up the release for something that has been unquestioned for nearly three years.

On Wed, Mar 14, 2018 at 1:00 PM Romain Manni-Bucau <rmannibucau@xxxxxxxxx> wrote:

Le 14 mars 2018 18:51, "John D. Ament" <johndament@xxxxxxxxxx> a écrit :
ASF policy is that NOTICE files are present when the consumed product includes a NOTICE file.  In BSD-3-Clause products, the copyright statement (including download link) is in the license file.  So its enough to list it there.

My vote: -1 due to incorrect NOTICE file.

It is not incorrect since the license is particular it must be in notice to be able to put all parts together on user side. If you dont you let users do again this job which is insanely bad.

On Wed, Mar 14, 2018 at 1:46 PM Romain Manni-Bucau <rmannibucau@xxxxxxxxx> wrote:

Le 14 mars 2018 18:30, "John D. Ament" <johndament@xxxxxxxxxx> a écrit :
Why does the NOTICE file in the resulting JAR (for the ASM shaded dependency) include

This product includes software developed at
OW2 Consortium (http://asm.ow2.org/)

There is no notice file associated with ASM 6.1, so we should not need to declare any notice.

Well it is not an asf licensed software nor an asf project so it is no bad IMHO to list it here. Also their website look a bit outdated so I was not sure it was that ok to completely drop it.

On Wed, Mar 14, 2018 at 12:54 PM Romain Manni-Bucau <rmannibucau@xxxxxxxxx> wrote:
yep, as written ;)

Romain Manni-Bucau
@rmannibucau |  Blog | Old BlogGithub | LinkedIn | Book

2018-03-14 17:51 GMT+01:00 Jean-Louis MONTEIRO <jeanouii@xxxxxxxxx>:

as far as I have seen, there is only the ASM upgrade, right?

Le mer. 14 mars 2018 à 17:49, Romain Manni-Bucau <rmannibucau@xxxxxxxxx> a écrit :

Please VOTE for the release of Apache XBean-4.7.

Here is the staging repo: https://repository.apache.org/content/repositories/orgapachegeronimo-1049
The source distribution can be found here: https://repository.apache.org/content/repositories/orgapachegeronimo-1049/org/apache/xbean/xbean/4.7/xbean-4.7-source-release.zip
sha1 is ea25f3fda5d9abea891a62abf738d1024f289dd5

Change is only about upgrade asm to 6.1 (java 10).

[+1] ship it
[+0] meh, don’t care
[-1] nope, stop because ${reason}

The VOTE is open for 72h.

Here is my +1.

Romain Manni-Bucau
@rmannibucau |  Blog | Old BlogGithub | LinkedIn | Book