osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: JIRA assignment


Thanks Fabian!

Let me know if I can help with backlog of PRs or with the 1.7 release.

-Joey

On Fri, Nov 16, 2018 at 1:46 AM Fabian Hueske <fhueske@xxxxxxxxx> wrote:

> Hi Joey,
>
> First of all, sorry for the bad contribution experience so far.
> I don't know the BlobManager well enough, otherwise I'd had a look at your
> PR.
>
> The Flink community (and committers especially) are currently overwhelmed
> with the number of PRs.
> We receive all kinds of contributions from large features with 1000+ LOC
> changes to bug fixes with very few changes (just like yours).
> I think we need to improve how we handle smaller PRs that are (mostly)
> relatively easy to review.
> In general, I think it is fine to send out a reminder, especially for PRs
> that fix a bug and should be easy to review.
>
> One thing that adds to the whole situation is that most of the committers
> are currently working towards the 1.7.0 release and spent less time on PR
> reviews.
>
> Best, Fabian
>
>
> Am Do., 15. Nov. 2018 um 20:34 Uhr schrieb Joey Echeverria <
> joey42@xxxxxxxxx>:
>
>> One quick follow up on this. The PR has been open for about a month. I
>> don't want to bug the folks to review it, but I'm not sure what the
>> etiquette is for getting PRs reviewed.
>>
>> Any help would be appreciated!
>>
>> Thanks!
>>
>> -Joey
>>
>> On Wed, Nov 7, 2018 at 6:44 AM Joey Echeverria <joey42@xxxxxxxxx> wrote:
>>
>> > Thanks Till!
>> >
>> > -Joey
>> >
>> > On Nov 7, 2018, at 02:32, Till Rohrmann <trohrmann@xxxxxxxxxx> wrote:
>> >
>> > I've given you permissions and assigned you to this ticket.
>> >
>> > Cheers,
>> > Till
>> >
>> > On Tue, Nov 6, 2018 at 7:25 PM Joey Echeverria <joey42@xxxxxxxxx>
>> wrote:
>> >
>> >> I submitted a PR[1] for FLINK-10213[2] awhile ago, but I couldn't
>> assign
>> >> the issue to myself or update it's status in JIRA. Is there anything I
>> >> need to do to get JIRA updated?
>> >>
>> >> Thanks!
>> >>
>> >> -Joey
>> >>
>> >> [1] https://github.com/apache/flink/pull/6862
>> >> [2] https://issues.apache.org/jira/browse/FLINK-10213
>> >>
>> >
>>
>