osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Flip23


Hi Boris,

Thanks for sharing the code that you'd like to contribute for FLIP-23.

I have a quick look at the repository and collected some stats to estimate
the reviewing effort for the contribution.
There are approx 1900 lines of Java and 2000 lines of Scala code.
This is a reasonable size that shouldn't be too hard to review.

Are the Java and Scala parts completely separated or does the Java API
depend on the Scala code (or the other way round)?
Would it be possible to merge the code in two separate steps?
I'm asking because it's typically faster to incrementally review and merge
larger features.
Another way to split the contribution would be to first add the simple
version than evolve it into the speculative one as a follow up (not sure if
that would make sense).

Btw. you posted the same link for simple and speculative model serving.

Best, Fabian

Am Do., 1. Nov. 2018 um 11:27 Uhr schrieb Till Rohrmann <
trohrmann@xxxxxxxxxx>:

> Thanks for sharing the code with the community Boris!
>
> Cheers,
> Till
>
> On Thu, Nov 1, 2018 at 10:29 AM Boris Lublinsky <
> boris.lublinsky@xxxxxxxxxxxxx> wrote:
>
> > For those who want to see an actual code, it is here:
> > https://github.com/FlinkML/flink-modelServer <
> > https://github.com/FlinkML/flink-modelServer> for simple model serving
> > And https://github.com/FlinkML/flink-modelServer <
> > https://github.com/FlinkML/flink-modelServer> for speculative one
> >
> > Boris Lublinsky
> > FDP Architect
> > boris.lublinsky@xxxxxxxxxxxxx
> > https://www.lightbend.com/
> >
> >
>