osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [DISCUSS] [Contributing] (3) - Review Tooling


As a new contributor I cared about how to make my contribution accepted by the community, some questions:
 1) When will it get reviewed? Is there a rule about review timeline? 
 2) There are long backlog of pull requests, What happened if a pull request not get noticed, do we have some mechanism to make it moving forward, like a pull request will be assigned a owner of reviewer? Or we have a review queue and a pull request will be get handled fairly. 

Jin 
 

> On Sep 20, 2018, at 12:56 PM, Stephan Ewen <sewen@xxxxxxxxxx> wrote:
> 
> Hi all!
> 
> This thread is dedicated to discuss the tooling we want to use for the
> reviews.
> It is spun out of the proposal *"A more structured approach to reviews and
> contributions".*
> 
> 
> *Suggestions brought up so far*
> 
> 
> *Use comments / template with checklist*
> 
>  - Easy to do
>  - Manual, a bit of reviewer overhead, reviewers needs to know the process
> 
> *Use a bot *
> 
>  - Automatically add the review questions to each new PR
>  - Further details?
> 
> *Use GitHub labels*
> 
>  - Searchable
>  - possibly not obvious to new contributors
>  - Any restrictions? Do members need to apply at ASF infra to have
> permissions to edit github labels?