osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[jira] [Created] (FLINK-10304) Remove deprecated AbstractYarnClusterDescriptor field


陈梓立 created FLINK-10304:
---------------------------

             Summary: Remove deprecated AbstractYarnClusterDescriptor field
                 Key: FLINK-10304
                 URL: https://issues.apache.org/jira/browse/FLINK-10304
             Project: Flink
          Issue Type: Improvement
          Components: Client, YARN
    Affects Versions: 1.7.0
            Reporter: 陈梓立
            Assignee: 陈梓立
             Fix For: 1.7.0


Depend on [~trohrmann@xxxxxxxxxx]'s [commit|https://github.com/apache/flink/commit/6356128865bff7463bf03185d18b129ed3633bc2], {{AbstractYarnClusterDescriptor}} should not care whether it is in DETACHED mode.

After digging I found the main usages of it are

1. {{FlinkYarnSessionCli#run}}, this can be resolved by checking whether {{allOptions}} has {{DETACHED_OPTION}} locally.

2. when AbstractYarnClusterDescriptor start a AM, it sets {{appMasterEnv.put(YarnConfigKeys.ENV_DETACHED, String.valueOf(detached));}}. At this point it seems that YarnClusterDescriptor should know whether or not it is in detached mode.

If usage 2 is irrelevant now, we can get rid of deprecated method in FLIP-6 codebase.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)