osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

ODP: How to handle tests that need docker?


Imho, 
Such tests should be off by default as they impose some requirements on the people trying to build Flink from source. And one would have to install docker only for the tests to pass. But of course they should be enabled for CI builds.

Best Regards,
Dominik.

Wysłane z aplikacji Poczta dla Windows 10

Od: Niels Basjes
Wysłano: czwartek, 16 sierpnia 2018 14:05
Do: dev@xxxxxxxxxxxxxxxx
Temat: How to handle tests that need docker?

Hi,

I'm working together with Richard Deurwaarder on the PubSub Source and Sink
https://issues.apache.org/jira/browse/FLINK-9311

We currently have most of the code done and we also have several tests that
verify the behavior by actually reading and writing messages to and from
PubSub.
These tests use a docker image provided by Google that includes the pubsub
emulator.

Starting and stopping this thing is really fast.
Starting up, creating topic, running a few tests and cleaning up takes
about 5 seconds.

Although the complete set of tests run on my machine in about 20-25 seconds
it does mean that anyone doing that MUST have docker installed locally.

So my question to the committers: Do we simply leave these tests "always
on" or do you want them to be "off by default" or something else.
I case you do not want the "always on" then please indicate how we should
implement the "on"/"off" switch for these tests.

Thanks.

-- 
Best regards / Met vriendelijke groeten,

Niels Basjes