osdir.com


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: 'mvn verify' fails on rat plugin


Does such a change require JIRA?

https://flink.apache.org/contribute-code.html says: "... with an exception for trivial hot fixes..." but when I go to create a pull request, I see: "Exceptions are made for typos in JavaDoc or documentation".
I see inconsistency here... :)


-----Original Message-----
From: Chesnay Schepler [mailto:chesnay@xxxxxxxxxx] 
Sent: Monday, July 09, 2018 4:24 PM
To: dev@xxxxxxxxxxxxxxxx; NEKRASSOV, ALEXEI <an4828@xxxxxxx>
Subject: Re: 'mvn verify' fails on rat plugin

These files are automatically detected as binary files on unix and thus automatically ignored by the RAT plugin, but not on Windows.
Most Flink devs run unix and don't run into this problem, and thus don't define a proper exclusion.
This happens regularly.

It would be great if you could open a PR to add the missing exclusions.

On 09.07.2018 21:47, NEKRASSOV, ALEXEI wrote:
> https://urldefense.proofpoint.com/v2/url?u=https-3A__flink.apache.org_contribute-2Dcode.html&d=DwIC3g&c=LFYZ-o9_HUMeMTSQicvjIg&r=aQRKg6d5fsz42zXkyiSdqg&m=BtUtXJtmUmFVBy9uXGsQs21fwy5dSvOHpeiXxLefQd8&s=_8QQZVgu0HFV2KxPaD6g8q4DHpRdXdvbjmV4u_STieg&e= recommends running 'mvn clean verify', but when I do (on master), the build fails:
>
> ...
> [INFO] Parsing exclusions from C:\usr\git\flink\.gitignore ...
> [INFO] Rat check: Summary over all files. Unapproved: 2, unknown: 2, generated: 0, approved: 8064 licenses.
> ...
> [INFO] flink .............................................. FAILURE [ 
> 20.726 s]
>
> Files with unapproved licenses:
>
>    flink-runtime/src/test/resources/heap_keyed_statebackend_1_2.snapshot
>    
> flink-runtime/src/test/resources/heap_keyed_statebackend_1_5_map.snaps
> hot
>
> Do we need to update .gitignore? For these two files only, or for some new pattern?
>
> Thanks,
> Alex
>