osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [VOTE] Release flink-shaded 4.0, release candidate #2


+1

I am new in this but I did following tests:

- mvn clean package -Dshade-sources passed will all modules SUCCESS
- checked all the licenses available
- netty-route license has been removed
- netty version 4.1.24.Final-4.0
- jackson version 2.7.9-4.0
- jackson-jsonSchema versio 2.7.9-4.0
- guava version 18.0-4.0
- asm version 5.0.4-4.0
- flink force shading version 4.0
- flink-shaded-netty-4 <https://github.com/apache/flink-shaded/tree/release-3.0/flink-shaded-netty-4>/packaged_licenses <https://github.com/apache/flink-shaded/tree/release-3.0/flink-shaded-netty-4/packaged_licenses>/LICENSE.jauter.txt removed
- flink-shaded-netty-4 <https://github.com/apache/flink-shaded/tree/release-3.0/flink-shaded-netty-4>/packaged_licenses <https://github.com/apache/flink-shaded/tree/release-3.0/flink-shaded-netty-4/packaged_licenses>/LICENSE.netty_router.txt removed


Cheers,
Yaz

> On May 30, 2018, at 10:29 AM, Piotr Nowojski <piotr@xxxxxxxxxxxxxxxxx> wrote:
> 
> I’m carrying over my +1
> 
>> On 30 May 2018, at 15:57, Chesnay Schepler <chesnay@xxxxxxxxxx> wrote:
>> 
>> +1
>> 
>> The checks i did for the previous RC are still valid.
>> Additionally i verified that the netty jar no longer bundles the licenses for netty-router.
>> 
>> On 30.05.2018 15:51, Chesnay Schepler wrote:
>>> Hi everyone,
>>> Please review and vote on the release candidate #2 for the version 4.0, as follows:
>>> [ ] +1, Approve the release
>>> [ ] -1, Do not approve the release (please provide specific comments)
>>> 
>>> The complete staging area is available for your review, which includes:
>>> * GitHub release notes [1],
>>> * the official Apache source release to be deployed to dist.apache.org <https://cwiki.apache.org/confluence/display/FLINK/dist.apache.org> [2], which are signed with the key with fingerprint 11D464BA [3],
>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>> * source code tag "release-4.0-rc2" [5].
>>> 
>>> The vote will be open for at least 72 hours. It is adopted by majority approval, with at least 3 PMC affirmative votes.
>>> 
>>> Thanks,
>>> Chesnay
>>> 
>>> [1] https://github.com/apache/flink-shaded/milestone/4?closed=1
>>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-shaded-4.0-rc2/
>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>> [4] https://repository.apache.org/content/repositories/orgapacheflink-1167/
>>> [5] https://gitbox.apache.org/repos/asf?p=flink-shaded.git;a=commit;h=33e86998fb8fe3d5b0a20260110d4ea636cc2528
>>> 
>>> 
>> 
>