[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Discussion] Fineract CN SMS & Email Notifications Project

Hi Ebenezer,

I was just looking through this thread and your ongoing work since May
2018.  Nice work.

In your design, I was wondering if there is a place to make messages
conditional on various flags in other data tables.  That is, as an example,
for some customers, we send out "Urgent Reminder, you missed last payment
and owe new amount" while for other customers we send out "Normal payment
due" message.  Is this sort of logic in scope?  Could you imagine that your
code could be extended in this direction?

Second, from a security point of view, have you noticed any
issues/challenges we should think about and then address in the overall
architecture?  I guess I am riffing off the use of an admin user as the
default account required for sending messages.  Is the scope of this user
at the right level for this task?  Is the permitted-feign-client
documentation useful and complete on cwiki?  You've been into this code now
for a while and may have useful observations that could benefit the

Third, once this service is available, does it automatically get included
in any deployment and/or is it optionally included and invoked?  This may
be a larger question for the architects, but I'm trying to understand how
the various available microservices would be combined (or not) in different
deployment situations.


On Thu, Oct 11, 2018 at 11:35 AM Myrle Krantz <myrle@xxxxxxxxxx> wrote:

> Hey Ebenezer,
> I really hope you keep the name Wada.  I love personal touches like
> this.  Hermes isn't Egyptian and his Egyptian counterpart Thoth is
> already taken by another service.  But far more important: Wada means
> something to you.
> No problem on the 404s  Your repos are public so it wasn't really an
> obstacle.
> Have you been able to make headway with my explanation?  If something
> is unclear please tell me.  But also keep in mind I have several
> deadlines coming up so I'm going to be slow in replying through the
> next week.
> Best Regards,
> Myrle
> On Mon, Oct 8, 2018 at 10:59 PM Ebenezer Graham
> <egraham15@xxxxxxxxxxxxxx> wrote:
> >
> > Wow! the reason for Anubis is deep. I should have consulted you for
> > suggestions.
> >
> > First of all apologies for the 404s. I clean up my repo ( squashed some
> > commits and deleted a few test branches) and so I had to force push to my
> > git repo when I wanted to pull onto the VM. All the new code on the
> > authentication is here
> >
> https://github.com/ebenezergraham/fineract-cn-notifications/tree/permitted-feign-client-auth
> .
> > I will be mindful of squash and force push next time.
> >
> > Wada means "To be loved".The notification service is my first ever open
> > source project and as a wannabe open source advocate this was a really
> big
> > deal for me hence *"my love for it".* Also partly because it's an
> > Indigenous Kalanga name, I am fascinated by southern African languages
> and
> > as such, I leave a trail of it on significant things in my life. :)
> >
> > But after reading the meaning of Anubis. I guess *hermes* would be a
> > perfect name. One of the twelve Olympian gods ( mostly known as the
> > messenger god). :0