OSDir


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Pull Request Review


Hey Cabrel,

I've merged your latest PR.  You are absolutely on a role!

Cabrel, can you please review Ruphine's PR?  If you say it's good,
then I'll merge it.

Best Regards,
Myrle
On Wed, Oct 17, 2018 at 5:32 PM Ruphine Kengne <ruphinekengne@xxxxxxxxx> wrote:
>
> Hello Myrle,
>
> I have sent the pull request
> https://github.com/apache/fineract-cn-fims-web-app/pull/12
> which solves the issue : https://issues.apache.org/jira/browse/FINCN-101
>
> Please can you review it?
>
> Regards,
> Ruphine Kengne
>
> On Wed, 17 Oct 2018 at 11:14, Cabrel Kemfang <ghislaincabrel.kemfang@xxxxxxxxx> wrote:
>>
>> Hello Myrle,
>> I have sent another pr
>> https://github.com/apache/fineract-cn-fims-web-app/pull/11  which solves
>> the issue https://issues.apache.org/jira/browse/FINCN-87.
>> Please can you review it?.
>>
>> On Tue, Oct 16, 2018 at 8:28 PM Myrle Krantz <myrle@xxxxxxxxxx> wrote:
>>
>> > Awesome Cabrel!
>> >
>> > : o),
>> > Myrle
>> > On Tue, Oct 16, 2018 at 1:01 PM Cabrel Kemfang
>> > <ghislaincabrel.kemfang@xxxxxxxxx> wrote:
>> > >
>> > > Hello Myrle,
>> > > I have send a pull request (
>> > https://github.com/apache/fineract-cn-fims-web-app/pull/10) which solves
>> > the issue: https://issues.apache.org/jira/browse/FINCN-99
>> > > Please can you review my pull request.
>> > >
>> > > Thanks
>> > >
>> > > On Thu, Oct 11, 2018 at 7:36 PM Myrle Krantz <myrle@xxxxxxxxxx> wrote:
>> > >>
>> > >> I've added you to the contributors role in Jira and assigned you the
>> > >> two tickets I know you've worked on and closed them.
>> > >>
>> > >> Keep up the good work!
>> > >> Myrle
>> > >> On Thu, Oct 11, 2018 at 8:14 PM Cabrel Kemfang
>> > >> <ghislaincabrel.kemfang@xxxxxxxxx> wrote:
>> > >> >
>> > >> > Hello Myrle,
>> > >> > I have create a Jira account  the user name is :cabrelkemfang
>> > >> >
>> > >> > On Thu, Oct 11, 2018 at 12:37 PM Myrle Krantz <myrle@xxxxxxxxxx>
>> > wrote:
>> > >> >
>> > >> > > Hey Cabrel,
>> > >> > >
>> > >> > > Can you please create a Jira account and tell me what your user name
>> > >> > > is?  Then I can assign bugs to you that I close.  I'd like to make
>> > >> > > sure that you get credit.
>> > >> > >
>> > >> > > Here's the signup:
>> > >> > > https://issues.apache.org/jira/secure/Signup!default.jspa
>> > >> > >
>> > >> > > Best Regards,
>> > >> > > Myrle
>> > >> > > On Thu, Oct 11, 2018 at 1:33 PM Myrle Krantz <myrle@xxxxxxxxxx>
>> > wrote:
>> > >> > > >
>> > >> > > > merged!
>> > >> > > > On Thu, Oct 11, 2018 at 10:43 AM Cabrel Kemfang
>> > >> > > > <ghislaincabrel.kemfang@xxxxxxxxx> wrote:
>> > >> > > > >
>> > >> > > > > Hello Myrle,
>> > >> > > > > I have send a pull request (
>> > >> > > https://github.com/apache/fineract-cn-fims-web-app/pull/9) which
>> > solves
>> > >> > > the issue: https://issues.apache.org/jira/browse/FINCN-88
>> > >> > > > > Please can you review my pull request.
>> > >> > > > >
>> > >> > > > > Thanks
>> > >> > >
>> >