osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fineract CN Group Finance bug report


Thanks Kelvin for these contributions. I will try to ping some folks to
review your PRs.

Ed

On Wed, Sep 26, 2018 at 8:29 AM Kelvin Ikome <kvnikome@xxxxxxxxx> wrote:

> Hi all,
>
> I have resolved the following issues on Fineract CN Group finance UI:
>
>    - https://issues.apache.org/jira/projects/FINCN/issues/FINCN-89
>    - https://issues.apache.org/jira/projects/FINCN/issues/FINCN-90
>    - https://issues.apache.org/jira/projects/FINCN/issues/FINCN-91
>    - https://issues.apache.org/jira/projects/FINCN/issues/FINCN-92
>
> In addition to that, I have created a pull request and I'm hoping it will
> be reviewed and merged. (Link to PR:
> https://github.com/apache/fineract-cn-group-finance/pull/7)
>
>
> On Sat, Sep 22, 2018 at 2:43 PM, Awasum Yannick <awasum@xxxxxxxxxx> wrote:
>
> > Hi Kelvin,
> >
> > Thanks for doing some QA on the New Web App.
> >
> > What version of NPM, NodeJS are you using?
> > Please can you send a PR for the issues you have resolved?
> >
> > Can you also fill and send in an icla to secreatary@xxxxxxxxxx ? You can
> > find it here: https://www.apache.org/licenses/icla.pdf
> > An individual Contribution license protects you as a Contributor as well
> as
> > the the Apache Foundation and its users; it does not change your rights
> to
> > use your own Contributions for any other purpose. When you submit your
> > icla, your PRs will be merged with ease.
> >
> > If you have sometime, can you also help check and do some QA on
> > fims-web-app?
> >
> > Thanks.
> > Awasum
> >
> > On Sat, Sep 22, 2018 at 1:27 PM Kelvin Ikome <kvnikome@xxxxxxxxx> wrote:
> >
> > > Hi everyone,
> > >
> > > I went through the UI for Fineract CN Group Finance (
> > > https://github.com/apache/fineract-cn-group-finance) a couple of days
> > ago.
> > > It looks good for a start however, I came across a couple of bugs
> > (details
> > > below) and I decided to spend time fixing some of the bugs.
> > >
> > > *Bugs*
> > >
> > >    - Login view
> > >    - Login component does not have a defined variable for password
> input
> > >    field visibility state and this results to build failures
> > >    - On the login component, password input field is visible by default
> > >    - On the login component, password input visibility toggle is
> reversed
> > >    - On the login component, no error message is shown when the user
> > enters
> > >    wrong credentials
> > >    - CenterFormComponent view does not have a definition for "staffs"
> > >    object array and this causes a failure when building the UI
> > >    - Issue with views: Components get added (instead of being replaced)
> > and
> > >    form some sort of list with the most recent at the top and every
> > > subsequent
> > >    component opened gets added to the list. The screenshot can be found
> > > here:
> > >    https://imgur.com/a/as7RPZs and the steps to replicate this issue
> can
> > > be
> > >    found below.
> > >
> > >
> > >    1. Login as "operator"
> > >    2. Click on "View Centers" on the left nav
> > >    3. Click on "show" from the list of centers
> > >    4. On the left nav, click on Employees, followed by Offices and any
> > >    other nav menu option you feel like
> > >
> > >
> > >    - Collection Sheet route not working. How to replicate: Login as
> > >    operator and click on "Collection Sheet" from the left nav
> > >    - "Alt + x" key combination not working for the search box in the
> top
> > >    nav bar
> > >    - "View Centers" menu option on the left nav is not visible on small
> > >    screen sizes even when I scroll to the bottom
> > >
> > > On the top nav bar...
> > >
> > >    - Clicking on "Group" routes to "Centers" from "Client" dropdown
> menu
> > >    - Clicking on "Centers" routes to "QuickAccess" from "Client"
> dropdown
> > >    menu
> > >    - No router link specified for "Accounting"
> > >    - Router links for both member and deposits on the reports dropdown
> > menu
> > >    are not working
> > >    - Operator doesn't seem to have access to Teller and Products on the
> > >    admin dropdown menu (this one might not be a bug)
> > >
> > > For anyone using the Group Finance user interface, please check to see
> if
> > > you can identify bugs
> > >
> > >
> > > Thanks,
> > > Kelvin Ikome
> > >
> > > On Sat, Sep 22, 2018 at 12:48 PM, Kelvin Ikome <kvnikome@xxxxxxxxx>
> > wrote:
> > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > *Hi everyone,I went through the new UI for Fineract CN
> > > > (https://github.com/apache/fineract-cn-group-finance
> > > > <https://github.com/apache/fineract-cn-group-finance>) a couple of
> > days
> > > > ago. It looks good for a start however, I came accross a couple of
> bugs
> > > > (details below) and I decided to spend some time fixing some of the
> > > > bugs.Bugs - Login view- Login component does not have a defined
> > variable
> > > > for password visibility and this results to build failure- Password
> > field
> > > > is visible by default- Password field visibility toggle is reverse-
> No
> > > > error message if user enters wrong credentials on login- Center view:
> > > > “CenterFormComponent” does not have a definition for “staffs” object
> > > array
> > > > and it results to build failure- Issue with views: Views get added
> > > (instead
> > > > of being replaced) and form some sort of a list with the most recent
> at
> > > the
> > > > top and every subsequent view opened gets added to the list.
> Screenshot
> > > can
> > > > be found here: https://imgur.com/a/as7RPZs <
> > https://imgur.com/a/as7RPZs>
> > > > and the steps to replicate the bug are shown below. 1. Login as
> > > operator2.
> > > > Click on “view centers” on the left nav3. Click on “show” from the
> > > “Manage
> > > > Centers” section entries4. On the left nav, click on Employees,
> > followed
> > > by
> > > > Offices followed by any other nav option you feel like - Collection
> > sheet
> > > > route not working. How to replicate: Login as operator and click on
> > > > “Collection” sheet from the left nav- On the top nav bar 1. Group
> > routes
> > > to
> > > > “Centers” view from “Clients” dropdown2. Center routes to
> “QuickAccess”
> > > > view from “Clients” dropdown3. No routerLink for “Accounting”4.
> Router
> > > > links for both member and deposit in “Reports” dropdown not working5.
> > > > Operator user doesn’t seem to have access to Teller and products in
> the
> > > > “Admin” dropdown (this one might not be a bug) - “Alt + x” key
> > > combination
> > > > not working for search box in the top nav- “View Centers” menu option
> > on
> > > > the left nav not visible on small screen size even when I scroll down
> > to
> > > > the endFor those using the group finance user interface, please check
> > to
> > > > see if you can identify bugs.Thanks, Kelvin Ikome.*
> > > >
> > >
> >
>


-- 
*Ed Cable*
President/CEO, Mifos Initiative
edcable@xxxxxxxxx | Skype: edcable | Mobile: +1.484.477.8649

*Collectively Creating a World of 3 Billion Maries | *http://mifos.org
<http://facebook.com/mifos>  <http://www.twitter.com/mifos>