[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fineract CN GSoC 2018 Interns: Send your PRs


Hello Graham,

Please send a PR of what you have done. Maybe someone can help.

On Sun, Aug 12, 2018 at 6:32 PM Ebenezer Graham <egraham15@xxxxxxxxxxxxxx>
wrote:

> Hi Awasum,
>
> No, I am haven't been able to get customer detail. I have created the user,
> role with READ permissions to the customer service and set the tenant and
> user context. But still getting the same error.
>
> Also, Courage volunteered to help me out.
>
> Apologies for the late reply, I wanted to get back to you with good news
> but things are not going as planned.
>
> *At your service,*
>
> *Ebenezer Graham*
>
> *BSc (Hons) Computing*
>
>
> [image: EmailSignature.png]
>
> African Leadership University,
>
> Power Mill Road, Pamplemousses,
>
> Mauritius.
>
>
> ​
> *skype*:
> ​ebenezer.graham
> GitHub <https://github.com/ebenezergraham> | LinkedIn
> <https://www.linkedin.com/in/ebenezer-graham/> | Twitter
> <https://twitter.com/pactmart> | Facebook
> <https://www.facebook.com/pactmart>
> www.pactmart.com | Freelancing made easy.
>
>
> *“Talk is cheap, show me the code.” *- *Linus Torvalds*
>
>
>
> On 2 August 2018 at 22:02, Awasum Yannick <awasum@xxxxxxxxxx> wrote:
>
> > Graham,
> >
> > Have you been able to solve your problem with the authentication?
> >
> > On Thu, Aug 2, 2018 at 6:58 PM Awasum Yannick <awasum@xxxxxxxxxx> wrote:
> >
> > > Hello Ruphine, Pembe,
> > >
> > > I merged your PRs for the front end. Thanks very much for your
> > > contributions so far. Keep up.
> > >
> > > Ruphine am still to review the new PR for the Groups backend.
> > >
> > > Write unit tests for the work done so far for both backend and front
> end
> > > if you touched both.
> > >
> > > Thanks.
> > > Awasum
> > >
> > > On Thu, Aug 2, 2018 at 4:58 PM Ruphine Kengne <ruphinekengne@xxxxxxxxx
> >
> > > wrote:
> > >
> > >> Hello,
> > >>
> > >> I have send some PRs as requested.
> > >>
> > >> One to fineract-cn-fims-web-app available here ,
> > >> https://github.com/apache/fineract-cn-fims-web-app/pulls
> > >>
> > >> and the other to fineract-cn-group available here ,
> > >> https://github.com/apache/fineract-cn-group/pulls
> > >>
> > >>
> > >> Regard
> > >> Ruphine kengne
> > >>
> > >> On 28 July 2018 at 09:08, Awasum Yannick <awasum@xxxxxxxxxx> wrote:
> > >>
> > >> > Hello Interns,
> > >> >
> > >> > Given we are near the end of GSoC 2018, I am recommending for
> everyone
> > >> to
> > >> > start sending in the PRs for the work we have done so far.
> > >> >
> > >> > I will be available to start reviewing today or tomorrow (Sunday).
> > >> > @Pembe Miriam <pembemiriam007@xxxxxxxxx> , I already started with
> > yours
> > >> > and
> > >> > left some comments here:
> > >> > https://github.com/apache/fineract-cn-group-finance/pull/2
> > >> >
> > >> > I also encourage you all to write unit tests for the work done so
> far
> > >> as we
> > >> > might not be able to merge your PRs without proper tests.
> > >> >
> > >> > Also write user and developer documentations for your work and add
> > more
> > >> > clarity on user stories and requirements which have evolved over the
> > >> course
> > >> > of the GSoC period so others can get context. Use confluence.
> > >> >
> > >> > I am available to answer questions if you are having problems mostly
> > in
> > >> my
> > >> > night period. I'm at GMT + 1 time zone. Lets try to get everyone
> > >> unblocked
> > >> > and complete the GSoC project within the next few weeks.
> > >> >
> > >> >
> > >> > Thanks.
> > >> > Awasum
> > >> >
> > >>
> > >
> >
>