Re: Fineract CN GSoC 2018 Interns: Send your PRs
Hello Ruphine, Pembe,
I merged your PRs for the front end. Thanks very much for your
contributions so far. Keep up.
Ruphine am still to review the new PR for the Groups backend.
Write unit tests for the work done so far for both backend and front end if
you touched both.
On Thu, Aug 2, 2018 at 4:58 PM Ruphine Kengne <ruphinekengne@xxxxxxxxx>
> I have send some PRs as requested.
> One to fineract-cn-fims-web-app available here ,
> and the other to fineract-cn-group available here ,
> Ruphine kengne
> On 28 July 2018 at 09:08, Awasum Yannick <awasum@xxxxxxxxxx> wrote:
> > Hello Interns,
> > Given we are near the end of GSoC 2018, I am recommending for everyone to
> > start sending in the PRs for the work we have done so far.
> > I will be available to start reviewing today or tomorrow (Sunday).
> > @Pembe Miriam <pembemiriam007@xxxxxxxxx> , I already started with yours
> > and
> > left some comments here:
> > https://github.com/apache/fineract-cn-group-finance/pull/2
> > I also encourage you all to write unit tests for the work done so far as
> > might not be able to merge your PRs without proper tests.
> > Also write user and developer documentations for your work and add more
> > clarity on user stories and requirements which have evolved over the
> > of the GSoC period so others can get context. Use confluence.
> > I am available to answer questions if you are having problems mostly in
> > night period. I'm at GMT + 1 time zone. Lets try to get everyone
> > and complete the GSoC project within the next few weeks.
> > Thanks.
> > Awasum