OSDir


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Pull Request 452


I have reviewed the PR and requested for minor change.

On Wed, Aug 1, 2018, 1:10 PM Ed Cable <edcable@xxxxxxxxx> wrote:

> Shruthi,
>
> Could you please review this PR? @Steve Conrad <sconrad1@xxxxxxxxx> or any
> of our commiters, could you then merge it in?
>
> Thanks,
>
> Ed
>
> On Tue, Jul 31, 2018 at 7:53 PM Brian C Cooke <tonic889@xxxxxxxxx> wrote:
>
> > Hi, just wondering if there's any updates on this PR.
> >
> > Thanks,
> > Brian
> >
> > On Wed, Jul 25, 2018 at 11:30 PM, Santosh Math <
> > santosh@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > > Hi Brian,
> > >
> > > Thanks. Sure.I will let u know.
> > >
> > >
> > >
> > > On Thu 26 Jul, 2018, 7:01 AM Brian C Cooke, <tonic889@xxxxxxxxx>
> wrote:
> > >
> > >> Thanks Santosh.  I have created JIRA Issue 642 on the Fineract side
> and
> > >> noted the same in my pull request #452.
> > >>
> > >> https://issues.apache.org/jira/browse/FINERACT-642
> > >> https://github.com/apache/fineract/pull/452
> > >>
> > >> Please let me know if there's anything else I can do to help get this
> PR
> > >> approved.
> > >>
> > >> Thanks,
> > >> Brian
> > >>
> > >> On Wed, Jul 25, 2018 at 12:48 AM, Santosh Math <
> > >> santosh@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > >>
> > >>> Hi Brian,
> > >>>
> > >>> Yes, that's correct. When an issue requires changes for both Fineract
> > >>> and Community App , we raise the  same ticket for both.
> > >>>
> > >>> Thanks
> > >>> Santosh
> > >>>
> > >>> On Wed, Jul 25, 2018 at 5:41 AM, Brian C Cooke <tonic889@xxxxxxxxx>
> > >>> wrote:
> > >>>
> > >>>> When you say "Please share the Fineract ticket" does that mean there
> > >>>> should be a JIRA ticket for the Fineract-side changes in addition to
> > the
> > >>>> Jira issue in the community app?  If there is not one, should I open
> > it
> > >>>> myself?
> > >>>>
> > >>>> Sorry, I am new to this process.
> > >>>>
> > >>>> Thanks,
> > >>>> Brian
> > >>>>
> > >>>>
> > >>>>> Hi Brian,
> > >>>>>
> > >>>>> Please share the Fineract ticket for the
> https://github.com/apache/
> > >>>>> fineract/pull/452 pull request which is sent to resolve following
> > >>>>> Community app ticket.
> > >>>>>
> > >>>>> https://github.com/openMF/community-app/issues/1863
> > >>>>>
> > >>>>> Thanks
> > >>>>> Santosh
> > >>>>>
> > >>>>>
> > >>>> On Sun, Jul 22, 2018 at 8:24 PM, Brian C Cooke <tonic889@xxxxxxxxx>
> > >>>> wrote:
> > >>>>
> > >>>>> Hi, I submitted a pull request some time ago and no action has been
> > >>>>> taken upon it to date. What should I do to get this request approve
> > and
> > >>>>> have it pushed into the codebase?  I'm a bit of a newbie so any
> > input would
> > >>>>> be appreciated.  Thanks!
> > >>>>>
> > >>>>> https://github.com/apache/fineract/pull/452
> > >>>>>
> > >>>>> Thanks,
> > >>>>> Brian
> > >>>>>
> > >>>>
> > >>>>
> > >>>
> > >>>
> > >>> --
> > >>> Thanks & Regards
> > >>>
> > >>> Santosh Math
> > >>>
> > >>> *QA Engineer*
> > >>>
> > >>> *Conflux Technologies Pvt Ltd <http://www.confluxtechnologies.com/>*
> > >>> | *Office*: +91-080-41208662 |
> > >>>
> > >>> *Address*: #304, 2nd Floor, 7th Main Road, HRBR Layout 1st Block,
> > >>> Bengaluru, Karnataka, 560043 INDIA
> > >>>
> > >>
> > >>
> >
>
>
> --
> *Ed Cable*
> President/CEO, Mifos Initiative
> edcable@xxxxxxxxx | Skype: edcable | Mobile: +1.484.477.8649
>
> *Collectively Creating a World of 3 Billion Maries | *http://mifos.org
> <http://facebook.com/mifos>  <http://www.twitter.com/mifos>
>