Re: Code Committ Process for Fineract Committers
I was able to merge PRs using the process described in this document:
Myrle created this doc and I made a few updates to it.
However, it may be that we need to use this GitBox process moving forward.
I did just go through the process that Ed describes above and it's quite
easy. I had to go to id.apache.org and set my GitHub user id and then
accept the invitation that came from ASF. You can check your GitHub
organizations in Settings->Organizations. You also need to have 2FA enabled
on your GitHub account.
On Fri, Jul 27, 2018 at 10:54 AM Ed Cable <edcable@xxxxxxxxx> wrote:
> Hello all,
> @Shruthi M R <shruthi@xxxxxxxxxxxxxxxxxxxxxxx> was working with some of
> the committers to get the recent self-service APIs she created merged into
> the code base. Both @Nazeer Hussain Shaik <nazeerhussain.shaik@xxxxxxxxx>
> and @Nayan Ambali <nayan.ambali@xxxxxxxxx> didn't think they had
> permission to merge the code so I think there's confusion regarding the
> code commit process for committers that I wanted to share on list.
> Pull requests aren't actually merged through Github but rather through
> Gitbox as described at https://gitbox.apache.org/setup/
> Necessary prerequisites for committers to have the above setup work is
> being added to the Fineract committer roster, having your GitHub ID
> associated with ASF ID, and 2FA enabled.
> @Steve Conrad <sconrad1@xxxxxxxxx> , @Avik Ganguly
> <avikganguly010@xxxxxxxxx> could you give feedback to others as I know
> you recently went through this process.
> @Isaac Kamga <isaac.kamga@xxxxxxxxx> , @Santosh Math
> <santosh@xxxxxxxxxxxxxxxxxxxxxxx> - could you work on improving
> documentation on Fineract to reflect this process for committers?
> Would you also be able to try and merge these incoming pull requests? See
> https://github.com/apache/fineract/pull/461 ------ Fineract -611 unable
> to create share product
> https://github.com/apache/fineract/pull/463 ------ Fineract- 628
> Savings account Api for Self Service App
> *Ed Cable*
> President/CEO, Mifos Initiative
> edcable@xxxxxxxxx | Skype: edcable | Mobile: +1.484.477.8649
> *Collectively Creating a World of 3 Billion Maries | *http://mifos.org
> <http://facebook.com/mifos> <http://www.twitter.com/mifos>