osdir.com

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] therajanmaurya commented on a change in pull request #1: feat : fake database layer


therajanmaurya commented on a change in pull request #1: feat : fake database layer
URL: https://github.com/apache/fineract-cn-mobile/pull/1#discussion_r192008926
 
 

 ##########
 File path: app/src/main/java/org/apache/fineract/data/models/loan/LoanAccount.java
 ##########
 @@ -127,7 +126,7 @@ public void setLastModifiedBy(String lastModifiedBy) {
     }
 
     public LoanParameters getLoanParameters() {
-        return new Gson().fromJson(parameters, LoanParameters.class);
+        return loanParameters;
 
 Review comment:
   I think I made this because of some code restriction, change it as it was when you will work in this then we will see this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@xxxxxxxxxxxxxxxx


With regards,
Apache Git Services