OSDir


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] leventov commented on a change in pull request #6041: Synchronize scheduled poll() calls in SQLMetadataSegmentManager


leventov commented on a change in pull request #6041: Synchronize scheduled poll() calls in SQLMetadataSegmentManager
URL: https://github.com/apache/incubator-druid/pull/6041#discussion_r204921786
 
 

 ##########
 File path: server/src/main/java/io/druid/metadata/SQLMetadataSegmentManager.java
 ##########
 @@ -340,7 +357,9 @@ public boolean removeSegment(String ds, final String segmentID)
   @Override
   public boolean isStarted()
   {
-    return started;
+    synchronized (lock) {
 
 Review comment:
   Perf change is unimportant? It might wait for long scheduled `poll()`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@xxxxxxxxxxxxxxxx


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxxxx